Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-cli: head uses go@1.17 #90072

Closed
wants to merge 1 commit into from

Conversation

cglong
Copy link
Contributor

@cglong cglong commented Nov 28, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Following kubernetes/kubernetes#103692, this PR changes kubernetes-cli to build using Go 1.17 when building from HEAD. This will also be needed when the next minor release (v1.23) is released.

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Nov 28, 2021
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Nov 28, 2021
Formula/kubernetes-cli.rb Outdated Show resolved Hide resolved
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cglong cglong deleted the kubernetes-cli/go1.17 branch November 28, 2021 21:14
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants