Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crystal 0.36.1 #70236

Closed
wants to merge 1 commit into from
Closed

crystal 0.36.1 #70236

wants to merge 1 commit into from

Conversation

bcardiff
Copy link
Contributor

@bcardiff bcardiff commented Feb 2, 2021

There is a new patch release for Crystal.
It supports llvm@11.

Support for M1 should be on the way, but is not included just yet. Ref: crystal-lang/crystal#10348 cc: @carlocab

@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Feb 2, 2021
@carlocab
Copy link
Member

carlocab commented Feb 2, 2021

Nice. I was thinking about the bdw-gc resource -- you use a patched version of this, but this patch has already been accepted upstream.

Would crystal be able to depend on the bdw-gc formula, if the patch were applied to the formula?

@bcardiff
Copy link
Contributor Author

bcardiff commented Feb 2, 2021

Would crystal be able to depend on the bdw-gc formula, if the patch were applied to the formula?

Yes. But although that would leave the generated binaries by crystal with a dependency to that library instead of statically linking it as today. That could be an issue in linux since is one more library to track on deployment of the binary. Although is the same story as any other library. But yes, it should work.

@SMillerDev
Copy link
Member

Yes. But although that would leave the generated binaries by crystal with a dependency to that library instead of statically linking it as today.

That's what brew is here to manage though.

@bcardiff
Copy link
Contributor Author

bcardiff commented Feb 2, 2021

Sure @SMillerDev but as long as the distributed binary is still published in brew. So, unless I am missing something, it will be harder to share locally built binaries because of non static dependencies. But again, it should work, and for development cycles there should be no difference.

@BrewTestBot
Copy link
Member

:shipit: @dtrodrigues has triggered a merge.

@carlocab carlocab mentioned this pull request Feb 3, 2021
5 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 5, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants