Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 7.3.8 #42672

Closed
wants to merge 1 commit into from
Closed

php 7.3.8 #42672

wants to merge 1 commit into from

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Aug 1, 2019

Updated formula to php 7.3.8.

@request-info
Copy link

request-info bot commented Aug 1, 2019

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Aug 1, 2019
@Toflar
Copy link
Contributor Author

Toflar commented Aug 2, 2019

Hey @derrabus, this is my first contribution to the formula. Can you tell me what else I need to do (and maybe show me that brew bump-formula-pr thingy at SymfonyCon 😄 ).

@derrabus
Copy link
Contributor

derrabus commented Aug 2, 2019

@Toflar The PR looks good to me. The bot probably expected the PR title to be <formula> <version>, so in this case "php 7.3.8" (without the @) and in case of #42671 "php@7.2 7.2.21", but that's a guess. I'm just an occasional contributor myself. 🤷‍♂

@Toflar Toflar changed the title php@7.3.8 php 7.3.8 Aug 2, 2019
@derrabus
Copy link
Contributor

derrabus commented Aug 6, 2019

pinging @SMillerDev because you've merged previous PRs on the php formulae: Is there anything we can do to move this forward? This release contains an important fix for Symfony, see symfony/symfony#32395.

@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Aug 6, 2019
@SMillerDev
Copy link
Member

Thanks @Toflar

@danherd
Copy link

danherd commented Aug 6, 2019

Would be great if #42671 could be merged ASAP as well, as that also fixes the Symfony bug.

@SMillerDev
Copy link
Member

It'd be even better if I'd get generously payed tons of money for my open source contributions. But until, and even when, that's the case you'll have to wait until someone has time. In my case that means waiting until I'm done with my day job.

@danherd
Copy link

danherd commented Aug 6, 2019

It'd be even better if I'd get generously payed tons of money for my open source contributions. But until, and even when, that's the case you'll have to wait until someone has time. In my case that means waiting until I'm done with my day job.

I really appreciate what you've done here and I apologise for hassling you.

@SMillerDev
Copy link
Member

@BrewTestBot test this please!

@SMillerDev SMillerDev removed the needs response Needs a response from the issue/PR author label Aug 6, 2019
@SMillerDev SMillerDev closed this in 2b95cfa Aug 8, 2019
@Toflar Toflar deleted the patch-2 branch August 8, 2019 21:47
@lock lock bot added the outdated PR was locked due to age label Jan 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants