Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache-pulsar: enable arm build #168487

Closed
wants to merge 1 commit into from
Closed

apache-pulsar: enable arm build #168487

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Apr 9, 2024 •
edited

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle long build Needs CI-long-timeout labels Apr 9, 2024
@chenrui333 chenrui333 removed the long build Needs CI-long-timeout label Apr 9, 2024
ZhongRuoyu
ZhongRuoyu reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build still fails on ARM.

apache/pulsar#16639 only mentions that it can be built with Rosetta. Can it be built natively?

@chenrui333
Copy link
Member Author

Looks like not. I will need to create a new upstream issue for this.

@chenrui333
apache-pulsar: enable arm build
034c5cf 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title apache-pulsar: build with jdk21 and enable arm build apache-pulsar: enable arm build Apr 12, 2024
@github-actions github-actions bot added the long build Needs CI-long-timeout label Apr 12, 2024
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed long build Needs CI-long-timeout labels Apr 12, 2024
@chenrui333 chenrui333 mentioned this pull request Apr 19, 2024
Open
3 tasks
@chenrui333
Copy link
Member Author

@chenrui333 chenrui333 added upstream issue An upstream issue report is needed build failure CI fails while building the software labels Apr 19, 2024
@chenrui333
Copy link
Member Author

gonna close for now.

@chenrui333 chenrui333 closed this Apr 19, 2024
@chenrui333 chenrui333 deleted the apache-pulsar-jdk21 branch April 19, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu left review comments

Assignees
No one assigned
Labels
build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenrui333 @ZhongRuoyu