Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run brew style --fix #104617

Merged
merged 22 commits into from Jun 28, 2022
Merged

Run brew style --fix #104617

merged 22 commits into from Jun 28, 2022

Conversation

MikeMcQuaid
Copy link
Member

Needed for Homebrew/brew#13477

Includes a few manual fixes.

@MikeMcQuaid MikeMcQuaid added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jun 28, 2022
@MikeMcQuaid MikeMcQuaid enabled auto-merge (rebase) June 28, 2022 09:54
@MikeMcQuaid MikeMcQuaid enabled auto-merge (rebase) June 28, 2022 10:06
Formula/gspell.rb Show resolved Hide resolved
@@ -160,7 +160,7 @@ def caveats
-LUA_A= liblua.a
+LUA_A= liblua.5.1.5.dylib
CORE_O= lapi.o lcode.o ldebug.o ldo.o ldump.o lfunc.o lgc.o llex.o lmem.o \
lobject.o lopcodes.o lparser.o lstate.o lstring.o ltable.o ltm.o \
lobject.o lopcodes.o lparser.o lstate.o lstring.o ltable.o ltm.o \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive and will break this patch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 Good catch. Will disable this cop for homebrew/core for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 Removed this commit in latest push

Formula/sratoolkit.rb Outdated Show resolved Hide resolved
@Bo98 Bo98 disabled auto-merge June 28, 2022 11:54
@Bo98
Copy link
Member

Bo98 commented Jun 28, 2022

rubocop/rubocop#10763

@MikeMcQuaid MikeMcQuaid enabled auto-merge (rebase) June 28, 2022 13:14
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeMcQuaid
Copy link
Member Author

@chenrui333 Can I get a ✅? Thanks ❤️

@MikeMcQuaid MikeMcQuaid merged commit 3d4fd9e into Homebrew:master Jun 28, 2022
@MikeMcQuaid MikeMcQuaid deleted the brew_style_fix branch June 28, 2022 16:32
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants