Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert language mixins back to module_function #15259

Merged
merged 1 commit into from Apr 18, 2023

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Apr 18, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

See #15249 (comment)

cc @Bo98

@Bo98 Bo98 enabled auto-merge April 18, 2023 13:19
@dduugg dduugg added the critical Critical change which should be shipped as soon as possible. label Apr 18, 2023
@Bo98
Copy link
Member

Bo98 commented Apr 18, 2023

Happy to see this disappear the other way round (no module_function but also no self.) if you think it's worth it at some point (not in this PR since we need this to fix some homebrew-core CI).

@Bo98 Bo98 merged commit d039f46 into Homebrew:master Apr 18, 2023
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks @dduugg and @Bo98! This probably warrants:

  • a rubocop at some point to disable/discourage additional module_function usage
  • a comment on these modules so no-one comes along later and does this again

@dduugg dduugg deleted the revert-mixin-changes branch April 18, 2023 16:55
@dduugg
Copy link
Sponsor Member Author

dduugg commented Apr 18, 2023

Thanks @dduugg and @Bo98! This probably warrants:

  • a rubocop at some point to disable/discourage additional module_function usage

I filed this in 2019, maybe I should actually build the thing…

  • a comment on these modules so no-one comes along later and does this again

That, or tests that cover this case 😇

@dduugg dduugg mentioned this pull request Apr 19, 2023
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants