utils/popen: add safe
argument to popen_read
and popen_write
#10305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Follow-up to #10245
This PR adds a
safe
argument topopen_read
andpopen_write
that can then be used inUtils.git_head
The reason for adding this is that formulae use
safe_popen_read
to get the git head, whileUtils.git_head
currently usespopen_read
. SinceUtils.git_head
should primarily be used by formulae, this PR adds asafe
argument togit_head
that has a default value oftrue
(whereas the default value isfalse
forpopen_read
)I also added tests for
safe_popen_read
andsafe_popen_write
which passed with the original methods as seen in the test runs for commit 40d85ec: https://github.com/Homebrew/brew/runs/1689977863