Fix dependencies #90
Merged
Fix dependencies #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked down some problems with
npm installandnpm run serve:src/external/vue-grid-layoutdepended onnode-sass, which is deprecated. changed the dependency tosass, which is supported and works exactly the samevuewas importing some babel plug (babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining), which wasn't present in the version of@babel/preset-envspecified in the lockfile, so I updated@babel/preset-envto7.13.12, which included this PR Implement @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining babel/babel#13009 that fixes the issueAfter this I can successfully
npm installandnpm run serve. I tested this locally with a freshgit cloneof my fork's dev branch, using npm7.7.5.