Rewrite project to TS #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Wenn911
commented
Sep 25, 2022
Wenn911
commented
- Installed TS libraries
- Configurated tsconfig & webpack.config file
- Added interfaces
- Added types for the component propses
- Added types for function parameters and logic
|
@Wenn911 тут сборка упала |
|
Поправил, должно работать |
|
@Wenn911 что-то всё равно не собирается |
|
Так понимаю ошибка с вебпаком связана, подкрутил tsconfig, может сейчас пройдут тесты. Если нет, то буду вебпак смотреть, хотя на мой взгляд там все нормально |
|
@Wenn911 похоже надо смотреть вебпак |
|
Оказалась очень глупая ошибка из-за невнимательности, запушил, должно пройти |
|
@ashikov Деплой не проходит, пишет доступа нет |
|
Пр не забыт. Работа ведётся |
|
@dzencot всё ещё не забыт? :) |
|
@ashikov забыт( |
|
@dzencot тут все повисло. Какой итог? Ты доделываешь ПР? |
|
@fey к сожалению забыл посмотреть. На этой неделе займусь. Заведу тикет |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.