Add Synergy Support for Logical Interconnect Groups

[adarobin]

I am not able to create Logical Interconnect Groups with Terraform as described in #47

I am working to resolve this issue, though it appears there are multiple fields needed to successfully create a LIG.

[adarobin]

I'm not sure why CI is failing. The file it is complaining about has been run through gofmt.

[patrickdappollonio]

Hello @adarobin,

Can you run this command and tell me if it reports any Go files?

find . -type f -name "*.go" -not -path "./vendor/*" | sed "s|^\./||" | xargs gofmt -l

[adarobin]

@patrickdappollonio

m-c02tv2lthtd7:terraform-provider-oneview adarobin$ find . -type f -name "*.go" -not -path "./vendor/*" | sed "s|^\./||" | xargs gofmt -l
oneview/resource_ethernet_network.go
oneview/resource_fc_network.go
oneview/resource_fcoe_network.go
oneview/resource_network_set.go

Interesting that the files listed are not what is in the output from CI as having the error. I'll fix them up and do another commit.

[adarobin]

The only thing I'm not happy with is that I need to go back and manually set enclosure_indexes to [1] for all of my C7000 enclosures. I'd like to make [1] the default value, but that is not possible in the version of Terraform that this plugin is linked against.

[adarobin]

@patrickdappollonio
Now the files that were listed as needing fixed on my machine are listed in the CI. It appears to be a difference in gofmt behavior between versions. See golang/go#26228

m-c02tv2lthtd7:terraform-provider-oneview adarobin$ go version
go version go1.11.2 darwin/amd64

[soodpr]

@adarobin - Hi Adam. I have reviewed your PR and it looks good to me. May i know for which OneView API version you have tested this code?

[soodpr]

The only thing I'm not happy with is that I need to go back and manually set enclosure_indexes to [1] for all of my C7000 enclosures. I'd like to make [1] the default value, but that is not possible in the version of Terraform that this plugin is linked against.

Hello @adarobin - I agree we should use latest Terraform version. May be we can take this as an enhancement in future.

[soodpr]

LGTM 👍

[adarobin]

@soodpr I tested with API version 600.