Replace pbkdf2 by Argon2 in registrar #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argonautica seems to require clang, wich is missing from CI. |
HeroicKatora
requested changes
Apr 9, 2020
It should be possible to |
thespooler
force-pushed
the
argon2
branch
2 times, most recently
from
0d91110
to
8cb4861
Compare
|
It seems to work with the reference implementation of phc-winner-argon2 |
thespooler
force-pushed
the
argon2
branch
2 times, most recently
from
eb3cf1f
to
1e01b43
Compare
|
Ok, I think I got this. Except the two tasks that were |
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the current PBKDF2 password by Argon2 from the argonautica crate.
The tests looks good, so I did not find anything to add.
The only thing that I recon might be a point of concern is that store and check handles
[u8], whileHasheroperates onString, so I handle the utf8 conversion.I'm not quite sure that no security implications are hidden in there.