Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-use-form]: Upgrade immer + small tweaks #21

Merged
merged 1 commit into from Jan 22, 2021
Merged

[react-use-form]: Upgrade immer + small tweaks #21

merged 1 commit into from Jan 22, 2021

Conversation

jcarver989
Copy link
Contributor

This PR upgrades us to Immer 8.x. The main change there is it enables autoFreeze by default, which should result in a 7-8x performance boost due to a regression in 7x (which we were using), per immerjs/immer#681.

I snuck in two other unrelated changes:

  1. The license field in our package.json wasn't correctly formatted.
  2. I removed react-test-renderer as it wasn't being used and brought our testing library dep up to the latest.

@jcarver989 jcarver989 requested review from teeeteee, vly-ginger and a team January 22, 2021 17:13
gbryan
gbryan approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@gbryan gbryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and for removing the unused react-test-renderer!

@jcarver989 jcarver989 merged commit fc9a336 into master Jan 22, 2021
@jcarver989 jcarver989 deleted the enhancement/upgrade-deps branch January 22, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbryan gbryan gbryan approved these changes

@teeeteee teeeteee Awaiting requested review from teeeteee

@vly-ginger vly-ginger Awaiting requested review from vly-ginger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jcarver989 @gbryan