Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test, fix coding style and static analysis #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter279k
Copy link

@peter279k peter279k commented Jan 14, 2020

Changed log

  • Add php-7.4 version test during Travis CI build.
  • Fix coding style via PHP-CS-Fixer on GitHub actions.
  • Fix static analysis error via PHPStan on GitHub actions.
  • Add some path and message to ignoreErrors block on phpstan.neon.dist.
    It can pass some unnecessary error during static analysis error.
  • Installing some suggested dependencies to avoid most of errors during PHPStan static analysis.
  • According to this issue, it should upgrade the doctrine/annotations version to 1.8 to fix this issue.

@peter279k
Copy link
Author

@Nyholm, please look at this PR at your available time. Thanks :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant