Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Update octokit and omniauth-github to deal with url query params issue #459

Merged
merged 1 commit into from Aug 19, 2020

Conversation

katjuell
Copy link
Contributor

These updates should rid us of the warnings.

The bump on omniauth-github lets us take advantage of these changes, and the bump in octokit gives us these changes.

@katjuell katjuell requested a review from MattIPv4 August 17, 2020 19:54
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, app still seems to talk to GitHub

@katjuell katjuell merged commit 4ea80c4 into master Aug 19, 2020
@katjuell katjuell deleted the kjuell/update-github-auth branch August 19, 2020 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants