meson.build: add darwin/macOS dylib versioning #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
reviewed
Mar 10, 2024
| @@ -32,11 +36,22 @@ configure_file( | |||
| raqm_headers = files('raqm.h') | |||
| install_headers(raqm_headers) | |||
|
|
|||
| # ABI compatibility version should be that used for last non-meson release, 0.7.1 | |||
| raqm_ver_compat = 701 | |||
| raqm_ver_current = raqm_ver_major * 10000 + raqm_ver_minor * 100 + raqm_ver_micro | |||
There was a problem hiding this comment.
I don’t understand the significance of the last non-meson release here. All releases should be API and ABI-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the project migrated to Meson, Darwin/macOS dylib versioning was lost. This restores that functionality, ensuring that dependent binaries aren't broken.
In terms of the dylib compatibility version, it's set to 0.7.1. I believe that matches with what was used for 0.7.2, when built via AutoTools.