Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Add) Request #3650 #3744

Draft
wants to merge 5 commits into
base: 8.x.x
Choose a base branch
from
Draft

(Add) Request #3650 #3744

wants to merge 5 commits into from

Conversation

HDVinnie
Copy link
Collaborator

@HDVinnie HDVinnie commented Apr 9, 2024

No description provided.

- closes #3650
@HDVinnie HDVinnie linked an issue Apr 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@Roardom Roardom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review.

The suggestions on the freeleech function apply to the other buffs as well.

app/Http/Livewire/TorrentSearch.php Outdated Show resolved Hide resolved
app/Http/Livewire/TorrentSearch.php Outdated Show resolved Hide resolved
Comment on lines +722 to +723
$this->checked = [];
$this->selectPage = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does livewire have a function to reset the component to its initial state

app/Http/Livewire/TorrentSearch.php Show resolved Hide resolved
Comment on lines +803 to +807
foreach ($torrents as $torrent) {
$names[] = $torrent->name;

foreach (History::where('torrent_id', '=', $torrent->id)->get() as $pm) {
if (!\in_array($pm->user_id, $users)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to a trait to share with similar torrents

app/Http/Livewire/TorrentSearch.php Show resolved Hide resolved
@HDVinnie HDVinnie marked this pull request as draft April 15, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Option to select multiple torrents from main torrent page
2 participants