Test Csv() on Backslash Escaped Strings #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regular expression is often written with backslash escapes. This change introduces a test to check that the Csv helper does not strip backslashes from input strings.
kojiromike
commented
Dec 2, 2020
| @@ -228,6 +228,7 @@ def __call__(self, value): | |||
| transform = lambda s: self.cast(s.strip(self.strip)) | |||
|
|
|||
| splitter = shlex(value, posix=True) | |||
| splitter.escape = '' # Do not escape backslashes | |||
There was a problem hiding this comment.
@henriquebastos I want to call your attention to this line -- it fixes the issue for me, but may introduce backwards incompatibilities. I'm not sure if you have other users relying on this behavior. I would be happy with just this change, but let me know if you want me to introduce it via a new optional command arg or other backwards compatible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #102
A regular expression is often written with backslash escapes. This change introduces a test to check that the Csv helper does not strip backslashes from input strings.