fix: Bump protobuf to 3.19 and lock on minor version #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemonsy
changed the title
daemonsy
changed the title
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In feat: Remove erronous? lock to x86_64-linux #150, the intention was to remove the platform lock. In that PR,
google-protobufwas locked to3.13.xas per the gemspec and specs.However in reality, consumers could have been installing
3.19.xwhich I think is very common. We should relax the lock to minor version which lets people bump to the latest minor version.But I've also bumped the requirement to
~> 3.19because of this CVEThis should result in a bump to
2.1.0and that should be alright because of point 2 and if you're locked to below protobuf3.19, the major release should guard that