Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove erronous? lock to x86_64-linux #150

Merged
merged 1 commit into from
Jan 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
apollo-federation (1.1.5)
google-protobuf (~> 3.7)
google-protobuf (~> 3.13.0)
graphql (>= 1.9.8)

GEM
Expand Down Expand Up @@ -42,7 +42,7 @@ GEM
debase-ruby_core_source (0.10.9)
diff-lcs (1.3)
erubi (1.9.0)
google-protobuf (3.13.0-x86_64-linux)
google-protobuf (3.13.0)
graphql (1.10.10)
i18n (1.8.5)
concurrent-ruby (~> 1.0)
Expand Down Expand Up @@ -124,4 +124,4 @@ DEPENDENCIES
ruby-debug-ide

BUNDLED WITH
2.1.4
2.3.4
2 changes: 1 addition & 1 deletion apollo-federation.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Gem::Specification.new do |spec|

spec.add_dependency 'graphql', '>= 1.9.8'

spec.add_runtime_dependency 'google-protobuf', '~> 3.7'
spec.add_runtime_dependency 'google-protobuf', '~> 3.13.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to only keep the minor to 3.13 since this PR is only about removing the platform lock.

Also guessing typically if we wanted to lock versions, having it locked to patch and having the maintainers manually bump minor/major versions is more intention revealing.


spec.add_development_dependency 'actionpack'
spec.add_development_dependency 'appraisal'
Expand Down