-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[next][dace]: Skeleton of GTIR DaCe backend #1538
Open
edopao
wants to merge
64
commits into
GridTools:main
Choose a base branch
from
edopao:dace-fieldview
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
changed the title
feat[next][dace]: GTIR DaCe backend
feat[next][dace]: Skeleton of GTIR DaCe backend
Apr 24, 2024
edopao
commented
May 15, 2024
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py
Outdated
Show resolved
Hide resolved
egparedes
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good for me. I have some questions and comments about coding and typing style but they are minor.
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_to_tasklet.py
Outdated
Show resolved
Hide resolved
...t4py/next/program_processors/runners/dace_fieldview/gtir_builtins/gtir_builtin_symbol_ref.py
Outdated
Show resolved
Hide resolved
...t4py/next/program_processors/runners/dace_fieldview/gtir_builtins/gtir_builtin_symbol_ref.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtins/gtir_builtin_select.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtins/gtir_builtin_select.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/utility.py
Outdated
Show resolved
Hide resolved
Refactoring: import modules, not symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new DaCe backend that translates a GTIR program to SDFG. GTIR is still sometimes referred to as Combined-IR and provides a fieldview representation of the GT4Py program. The GT4Py frontend is not ready to lower a GT4Py program to GTIR, so for now the unit tests use manually written GTIR programs as input.
The new DaCe backend is implemented in the package
gt4py.next.program_processors.runners.dace_fieldview
This package provides, for now, the method
build_sdfg_from_gtir
to build the DaCe SDFG.This PR introduces translation capability for the following GTIR types:
ir.Program
,ir.Stmt
,ir.SetAt
. And for the following new builtin functions:as_field_op
andselect
.