Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor[next]: cleaner toolchain #1537

Merged
merged 38 commits into from
May 21, 2024
Merged

refactor[next]: cleaner toolchain #1537

merged 38 commits into from
May 21, 2024

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Apr 23, 2024 •
edited

Description

Added:

  • otf.workflow:

    • new workflow type: NamedStepSequenceWithArgs
      takes an InputWithArgs and dispatches .args and .kwargs to steps that set take_args = True in the field metadata
    • new data type InputWithArgs wraps a workflow stage and call args

  • backend: Replace *ArgsInjector using the new NamedStepSequenceWithArgs infrastructure

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

DropD added 30 commits March 26, 2024 16:57
@DropD
workflowify past linting and args injection
b0f7e3a
@DropD
workflowify func -> FOAST
445b35d
@DropD
fix missing attribute rename.
3561a0c
@DropD
workflowify FieldOperator.as_program
2842cad
@DropD
make sure scan operator attributes are properly hashed
3357d11
@DropD
Merge branch 'main' into c20-workflowify-step3
3aab3c8
@DropD
Merge branch 'main' into c20-workflowify-step3
44b3060
@DropD
add closure vars to hash for program definition
ebf164c
@DropD
[wip] integrating fieldop workflows
d3a7851
@DropD
update foast pretty printer doctest
a99fc48
@DropD
fix code quality issues
c71e0bf
@DropD
reuse content hashing code in ffront.stages
df648e8
@DropD
remove erroneously committed .python-version
1f5c336
@DropD
Merge remote-tracking branch 'upstream/main' into c20-workflowify-step3
2cab5b7
@DropD
re-apply Program.itir fix after merge
0a54c3d
@DropD
move backend transforms to next.backend
e1ed8d2
@DropD
add tested toolchain workthrough notebook
3e30ca2
@DropD
fix toolchain walkthrough notebook
9e50bd8
@DropD
put default toolchain steps into definitions
678bd67
@DropD
replace content_hash with dedicated cache key gen for ffront stages
fad81c0
@DropD
add typeignores for hash algorithms
af1a016
@DropD
downgrade singledispatch type hints for py < 310
556e8c5
@DropD
docstrings for AST based decorator wrappers
fba07f1
@DropD
todos for linting step calls in decorator wrappers
50bdea2
@DropD
comment first occurrence of backwards compat backend pattern
63121fd
@DropD
stages hasher: avoid recursing into non-stage dataclasses
04e407b
@DropD
Merge remote-tracking branch 'upstream/main' into c20-workflowify-step3
ba838f1
@DropD
rename ffront.stages.cache_key -> ffront.stages.fingerprint_stage
9bb341a
@DropD
improve ffront.stage fingerprinting
888017d
@DropD
update HashlibAlgorithm in eve
345ce8e
@DropD DropD marked this pull request as ready for review April 30, 2024 11:38
@DropD DropD requested review from havogt and egparedes May 14, 2024 08:46
havogt
havogt approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DropD DropD merged commit 32dde79 into GridTools:main May 21, 2024
51 checks passed
@DropD DropD deleted the c21-cleaner-toolchain branch May 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

@egparedes egparedes Awaiting requested review from egparedes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DropD @havogt