-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT4Py programs as DaCe SDFGConvertibles #1527
base: main
Are you sure you want to change the base?
Conversation
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
Just a general comment, I am wondering if DaCe offers alternatively the option to register the conversion functions, instead of having to make them part of the object. (E.g. like jax pytrees work) If only the current option is available I am wondering if we should go with a monkey patching approach to remove the dace import from unrelated modules. But this is for @egparedes to answer. (And we could think of the other option as a contribution to productice DaCe.) |
For now, I would go with the short term approach since we are in the testing/development phase. In the near future, I could create a PR in DaCe to address this topic. |
tests/next_tests/integration_tests/multi_feature_tests/ffront_tests/test_laplacian.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are getting closer. I am still trying to understand how things interact and where stuff belongs. Maybe we could have a chat and you could teach me the interface.
This feature is needed for implementing DaCe orchestration, e.g. in ICON4Py.