feat[next]: extend embedded implementation of premap()
#1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
force-pushed
the
extend_remap_embedded
branch
from
e9d9dc5
to
5e0b16b
Compare
egparedes
changed the title
premap()
Co-authored-by: Hannes Vogt <hannes@havogt.de>
Co-authored-by: Hannes Vogt <hannes@havogt.de>
Co-authored-by: Hannes Vogt <hannes@havogt.de>
|
I tried to fix all mentioned issued but there are still a couple of open points to discuss. Could you do another review pass? |
havogt
requested changes
May 14, 2024
src/gt4py/next/common.py
Outdated
| Examples: | ||
| >>> I, J = Dimension("I"), Dimension("J") | ||
| >>> domain = Domain(NamedRange(I, UnitRange(0, 10)), NamedRange(J, UnitRange(5, 15))) | ||
| >>> domain.slice_at[2, 2:5] |
There was a problem hiding this comment.
It might be confusing that slicing with int behaves different than for fields/arrays as it doesn't reduce rank. Any arguments pro this behavior?
There was a problem hiding this comment.
To avoid inconsistencies, slice_at now only accepts slices, not ints.
| new_domain = self.domain.replace(dim_idx, *new_ranges) | ||
| # Select actual implementation of the transformation | ||
| if not (conn_fields[0].kind & common.ConnectivityKind.TRANSFORM_DATA): | ||
| return _domain_premap(self, *conn_fields) |
There was a problem hiding this comment.
I think we had a test that didn't use the short-circuit path for Cartesian connectivity, but went through the expensive index->index mapping.
havogt
approved these changes
May 16, 2024
egparedes
changed the title
premap()premap()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the implementation of the
premapfield operation (previously namedremap, conceptually equivalent to a Contravariant Functor'scontramap) to support more efficient implementations of different use cases depending on the contents of the connectivity field.Added
gt4py.eve: new typing aliases and minor utilitiesChanged
gt4py.next.common:Domainto support creation of subdomains via slicing using the.slice_atattribute. The actual implementation comes from the now deletedgt4py.next.embedded.nd_array_field._relative_ranges_to_domain()function.ConnectivityKindto represent all known use casesCartesianConnectivityto support translation and relocationsremaptopremapgt4py.next.embedded.nd_array_field:premap()(oldremap) and add usage documentation_hypercube()->_hyperslice(),_compute_mask_ranges()->_compute_mask_slices()Removed
gt4py.next.embedded.nd_array_field:_relative_ranges_to_domain()function moved to anDomainattribute ingt4py.next.common