feat[next]: as_offset implementation in embedded #1397
Conversation
nfarabullini
changed the title
|
For later reference: |
|
cscs-ci run |
| @@ -198,8 +216,11 @@ def remap( | |||
| # then compute the index array | |||
| xp = self.array_ns | |||
| new_idx_array = xp.asarray(restricted_connectivity.ndarray) - current_range.start | |||
| # finally, take the new array | |||
| new_buffer = xp.take(self._ndarray, new_idx_array, axis=dim_idx) | |||
| if self._ndarray.ndim > 1 and restricted_connectivity_domain == new_domain: | |||
There was a problem hiding this comment.
Why the second part of this condition? restricted_connectivity_domain == new_domain
There was a problem hiding this comment.
to avoid entering this condition in cases like:
@gtx.field_operator
def testee(a: gtx.Field[[Vertex, KDim], float]) -> gtx.Field[[Edge, KDim], float]:
return a(E2V[0])There was a problem hiding this comment.
can you explain this if else branch and are you sure all cases are handled? I am confused...
There was a problem hiding this comment.
When using FieldOffsets, only the specific dimensions related to the offset are taken into account.
Say I have this field_operator:
@gtx.field_operator
def testee(a: gtx.Field[[Edge, KDim], int]) -> gtx.Field[[Vertex, KDim], int]:
tmp = neighbor_sum(a(V2E), axis=V2EDim)
return tmpHere the restricted_connectivity_domain will be over [Edge, V2E] and will exclude KDim. In this case using the regular xp.take works.
When using as_offset, xp.take is also ok to use if the offset_field contains only one dimension.
However, when restricted_connectivity_domain contains multiple dimensions that are exactly the same as in new_domain, we have seen that xp.take does not work and hence had to create _take_mdim
There was a problem hiding this comment.
but what about restricted_connectivity_domain.dims == new_domain.dims, but ranges are different?
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_as_offset.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run |
|
cscs-ci run |
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_as_offset.py
Outdated
Show resolved
Hide resolved
…test_as_offset.py Co-authored-by: Hannes Vogt <hannes@havogt.de>
…offset_embedded
|
cscs-ci run |
| offset_provider={"Ioff": IDim, "Koff": KDim}, | ||
| ref=a[2:], | ||
| comparison=lambda out, ref: np.all(out == ref), | ||
| ) |
There was a problem hiding this comment.
I noticed we might be missing another test case: let's say we have a 3D field but the offset field is only 2D. I think the expected semantic is probably as if the offset field would be broadcasted first. This might be related to my comment about
if self._ndarray.ndim > 1 and restricted_connectivity_domain == new_domain:
implementation of
as_offsetin embedded