test[next]: Add test for vertical boundary condition with scan #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehrengruber
commented
Jul 5, 2023
| @@ -817,7 +817,7 @@ def deref(self) -> Any: | |||
| assert isinstance(k_pos, int) | |||
| # the following range describes a range in the field | |||
| # (negative values are relative to the origin, not relative to the size) | |||
| slice_column[self.column_axis] = range(k_pos, k_pos + len(column_range)) | |||
| slice_column[self.column_axis] = range(k_pos, min(k_pos + len(column_range), column_range.stop)) | |||
There was a problem hiding this comment.
As discussed we want to implement a different solution (than written here) where the size of the column remains len(column_range), but is filled with UNDEFINED values for shifts that go out of bounds.
There was a problem hiding this comment.
Filling with undefined is probably not good enough, in case we do shift(K,-1)(shift(K,1)(inp)), I believe we need the original values in the full column. I think, this requires the same shift and intersect logic that we discussed for embedded field view.
Maybe the undefined implementation is good enough for many use-cases, but when it breaks it will be hard to find the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, WIP