Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing permission checks, move non-preflight resources to correct packages #19328

Merged
merged 8 commits into from May 16, 2024

Conversation

moesterheld
Copy link
Contributor

@moesterheld moesterheld commented May 13, 2024

Description

  • removes an unused rest resource
  • moves "regular" ca/certificate renewal endpoints into regular Graylog package structure
  • add missing permissions and annotations
  • add dummy permission not available in Graylog to preflight resources to make sure they are not accidentally exposed by binding them there

/nocl

Motivation and Context

fixes #18854

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@moesterheld moesterheld requested a review from todvora May 13, 2024 16:43
# Conflicts:
#	graylog2-server/src/main/java/org/graylog2/bootstrap/preflight/web/resources/PreflightResource.java
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@todvora todvora merged commit 0fac488 into master May 16, 2024
5 checks passed
@todvora todvora deleted the datanode/check-rest-resources branch May 16, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data node rest resources contains endpoints without permission checks
2 participants