Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed references to leader datanodes in UI #19324

Merged
merged 1 commit into from May 13, 2024
Merged

Removed references to leader datanodes in UI #19324

merged 1 commit into from May 13, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented May 13, 2024

/nocl

Description

The datanode doesn't use leader flags anymore. It shouldn't be visible anywhere in the UI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

gally47
gally47 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@gally47 gally47 merged commit 9482f45 into master May 13, 2024
6 checks passed
@gally47 gally47 deleted the fix/remove_leader_datanode_from_ui branch May 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47 gally47 approved these changes

@moesterheld moesterheld Awaiting requested review from moesterheld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@todvora @gally47