Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zstd dependency into the server #15411

Merged
merged 2 commits into from
May 3, 2023
Merged

Move zstd dependency into the server #15411

merged 2 commits into from
May 3, 2023

Conversation

mpfz0r
Copy link
Member

@mpfz0r mpfz0r commented May 3, 2023

We only had this as an enterprise dependency.
The server could use it through a transititive dependency of kafka-client. This however was version 1.4.5-6

which has an issue on M1 Macs: luben/zstd-jni#153

/nocl
/jenkins-pr-deps https://github.com/Graylog2/graylog-plugin-enterprise/pull/5125

We only had this as an enterprise dependency.
The server could use it through a transititive dependency of
kafka-client. This however was version 1.4.5-6

which has an issue on M1 Macs: luben/zstd-jni#153
@mpfz0r mpfz0r marked this pull request as ready for review May 3, 2023 13:14
Copy link
Contributor

@kodjo-anipah kodjo-anipah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@janheise janheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes it!

@janheise janheise merged commit 3f7b692 into master May 3, 2023
4 checks passed
@janheise janheise deleted the fix-zstd-dependency branch May 3, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants