New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid .java regeneration when source model file is not modified #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While also: 1. Upgrade reflection library due to ronmamo/reflections#273 2. Memoized list of classloaders as it's getting called on each processed file. 3. Added tests for SimpleCache 4. Added tests CodeGenerator fix 5. Minor adjustments
Replace groupId and version via custom command. Otherwise, maven will complain about mismatching version and groupId
Hi @afathonih! I have a question about JitPack. How is it related to the regeneration of java source files issue? Could the 2topics be separated into 2 PRs instead? Best Kristian |
Hi @KristianKarl , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My projects keep generating the test source files on every build although model files was not touched. Turned out,
isModified
method keeps returning true.This PR change
isModified
comparison to use milliseconds comparison instead of nativeequals
method fromFileTime
class.While also:
The following out was produced for 299 model files by
mvn graphwalker:generate-test-sources
.Before:
After: