polyfill buffer for WalletConnect on RainbowKit #166
Conversation
…the vitge.config.ts for the protocol-frontend
…/polyfill-buffer # Conflicts: # apps/protocol-frontend/vite.config.ts # yarn.lock
|
Not sure why the action is failing where it is however. |
This is a strange spot to fail. Going to look into it shortly -- did it build fine locally? |
|
build works for me locally |
|
There was a |
| @@ -15,6 +15,7 @@ | |||
| "@chakra-ui/react": "^1.8.8", | |||
| "@emotion/react": "^11.9.3", | |||
| "@emotion/styled": "^11.9.3", | |||
| "@esbuild-plugins/node-globals-polyfill": "^0.1.1", | |||
There was a problem hiding this comment.
I would like to grab your attention that this lib is not well maintained and have some issues.
You can find more here
- Find alternative for
@esbuild-plugins/node-globals-polyfillprettier/prettier#12054 - Stop recommending node-globals/node-builtins plugin rollup/rollup#2881
Simply put: it just paste couple of imports to every file which can lead to complex implications.
There was a problem hiding this comment.
Are you seeing a viable solution within these? Should we log this as debt and revisit?
There was a problem hiding this comment.
Actually I don't have a viable solution to suggest.
We need Keating & JP's input on that.
Linear Ticket
Fixes PRO-388, Looks like we need to polyfill this for Vite.
Description
RainbowKit requires some polyfills for Vite.
Status