Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @web-stories-wp prefix to karma packages name #8558

Merged
merged 10 commits into from Aug 6, 2021

Conversation

mohdsayed
Copy link
Contributor

@mohdsayed mohdsayed commented Aug 3, 2021

Context

Add @web-stories-wp prefix to karma packages name.

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Related: #8537 (comment)

@google-cla google-cla bot added the cla: yes label Aug 3, 2021
@mohdsayed mohdsayed self-assigned this Aug 3, 2021
@swissspidy

This comment has been minimized.

@swissspidy swissspidy changed the title Add @web-stories-wp prefix to karma packages name Add @web-stories-wp prefix to karma packages name Aug 3, 2021
@swissspidy swissspidy added the Type: Infrastructure Changes impacting testing infrastructure or build tooling label Aug 3, 2021
package.json Outdated Show resolved Hide resolved
@mohdsayed mohdsayed marked this pull request as ready for review August 6, 2021 04:32
@swissspidy swissspidy merged commit 15b97ca into main Aug 6, 2021
@swissspidy swissspidy deleted the fix/add-karma-package-prefix branch August 6, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants