Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock stylelint version #1913

Merged
merged 3 commits into from
May 29, 2020
Merged

Unlock stylelint version #1913

merged 3 commits into from
May 29, 2020

Conversation

dvoytenko
Copy link
Contributor

This fails for some internal stylelint reason. The message is:

"result.apply is not a function"

Stack:

    at node_modules/@stylelint/postcss-css-in-js/extract.js:267:13
    at Array.some (<anonymous>)
    at isStylePath (node_modules/@stylelint/postcss-css-in-js/extract.js:257:33)
    at CallExpression (node_modules/@stylelint/postcss-css-in-js/extract.js:347:41)
    at NodePath._call (node_modules/@babel/core/node_modules/@babel/traverse/lib/path/context.js:55:20)
    at NodePath.call (node_modules/@babel/core/node_modules/@babel/traverse/lib/path/context.js:42:17)
    at NodePath.visit (node_modules/@babel/core/node_modules/@babel/traverse/lib/path/context.js:90:31)
    at TraversalContext.visitQueue (node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:112:16)
    at TraversalContext.visitSingle (node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:84:19)
    at TraversalContext.visit (node_modules/@babel/core/node_modules/@babel/traverse/lib/context.js:140:19)

@dvoytenko dvoytenko requested a review from swissspidy May 20, 2020 22:13
@dvoytenko dvoytenko requested a review from pbakaus as a code owner May 20, 2020 22:13
@github-actions

This comment has been minimized.

Sign in to view
@codecov

This comment has been minimized.

Sign in to view
@swissspidy swissspidy removed the request for review from pbakaus May 21, 2020 07:52
@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Dependencies Pull requests that update a dependency file and removed Type: Infrastructure Changes impacting testing infrastructure or build tooling labels May 21, 2020
@swissspidy
Copy link
Collaborator

That's why I closed the Dependabot PRs, e.g. #1833, #1862. Was hoping they'd fix this upstream

@dvoytenko
Copy link
Contributor Author

That's why I closed the Dependabot PRs, e.g. #1833, #1862. Was hoping they'd fix this upstream

@swissspidy , yep, understood. But maybe that's not happening and we need to file a bug?

@swissspidy
Copy link
Collaborator

Yeah sounds like it

@swissspidy
Copy link
Collaborator

Upstream issue: stylelint/stylelint#4793

One suggested workaround there is to use stylelint --syntax "css-in-js"

Let's try that?

@swissspidy swissspidy added the AMP Format Issues that need to be addressed in the AMP story format label May 29, 2020
@swissspidy swissspidy merged commit 37f08b0 into master May 29, 2020
@swissspidy swissspidy deleted the fix/stylelint branch May 29, 2020 09:57
obetomuniz added a commit that referenced this pull request May 29, 2020
@obetomuniz
Merge branch 'master' into fix/composed-characters-crashing
95c6f4c 
* master: (107 commits)
  Update build script
  Update release assets workflow
  Bump @wordpress/data from 4.18.0 to 4.19.0 (#2114)
  Bump @wordpress/i18n from 3.12.0 to 3.13.0 (#2110)
  Bump @wordpress/e2e-test-utils from 4.7.0 to 4.8.0 (#2116)
  Bump @storybook/addon-actions from 6.0.0-beta.15 to 6.0.0-beta.17 (#2118)
  Bump lint-staged from 10.2.6 to 10.2.7 (#2113)
  Update eslint-plugin-react-hooks
  Unlock stylelint version (#1913)
  Bump @storybook/client-api from 6.0.0-beta.15 to 6.0.0-beta.17 (#2063)
  Bump @testing-library/jest-dom from 5.8.0 to 5.9.0 (#2111)
  Bump @storybook/addon-viewport from 6.0.0-beta.15 to 6.0.0-beta.17 (#2064)
  Bump @storybook/addon-knobs from 6.0.0-beta.15 to 6.0.0-beta.17 (#2065)
  Bump @storybook/addon-a11y from 6.0.0-beta.15 to 6.0.0-beta.17 (#2062)
  Bump @storybook/addon-backgrounds from 6.0.0-beta.15 to 6.0.0-beta.17 (#2061)
  Bump @storybook/addon-storysource from 6.0.0-beta.15 to 6.0.0-beta.17 (#2066)
  Bump karma-jasmine from 3.2.0 to 3.3.1 (#2102)
  Bump @storybook/react from 6.0.0-beta.15 to 6.0.0-beta.17 (#2068)
  Add storybook story for failed preview dialog (#2080)
  Bump @testing-library/dom from 7.5.9 to 7.6.0 (#2103)
  ...
obetomuniz added a commit that referenced this pull request May 29, 2020
@obetomuniz
Merge branch 'master' into fix/keydown-on-text-element
ab9a7c0 
* master: (133 commits)
  Update build script
  Update release assets workflow
  Bump @wordpress/data from 4.18.0 to 4.19.0 (#2114)
  Bump @wordpress/i18n from 3.12.0 to 3.13.0 (#2110)
  Bump @wordpress/e2e-test-utils from 4.7.0 to 4.8.0 (#2116)
  Bump @storybook/addon-actions from 6.0.0-beta.15 to 6.0.0-beta.17 (#2118)
  Bump lint-staged from 10.2.6 to 10.2.7 (#2113)
  Update eslint-plugin-react-hooks
  Unlock stylelint version (#1913)
  Bump @storybook/client-api from 6.0.0-beta.15 to 6.0.0-beta.17 (#2063)
  Bump @testing-library/jest-dom from 5.8.0 to 5.9.0 (#2111)
  Bump @storybook/addon-viewport from 6.0.0-beta.15 to 6.0.0-beta.17 (#2064)
  Bump @storybook/addon-knobs from 6.0.0-beta.15 to 6.0.0-beta.17 (#2065)
  Bump @storybook/addon-a11y from 6.0.0-beta.15 to 6.0.0-beta.17 (#2062)
  Bump @storybook/addon-backgrounds from 6.0.0-beta.15 to 6.0.0-beta.17 (#2061)
  Bump @storybook/addon-storysource from 6.0.0-beta.15 to 6.0.0-beta.17 (#2066)
  Bump karma-jasmine from 3.2.0 to 3.3.1 (#2102)
  Bump @storybook/react from 6.0.0-beta.15 to 6.0.0-beta.17 (#2068)
  Add storybook story for failed preview dialog (#2080)
  Bump @testing-library/dom from 7.5.9 to 7.6.0 (#2103)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
AMP Format Issues that need to be addressed in the AMP story format Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dvoytenko @swissspidy @spacedmonkey @googlebot