Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fixes #2752" #3132

Merged
merged 2 commits into from May 14, 2024
Merged

"Fixes #2752" #3132

merged 2 commits into from May 14, 2024

Conversation

Samarth08
Copy link
Contributor

@Samarth08 Samarth08 commented Apr 22, 2024

Making --no-push and remote caching work with each other/

Fixes #2752

Description
• Setting NoPush to opts.NoPush instead of hardcoding it.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes
Fixes#2752
Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

--no-push and remote caching dont work with each other
Copy link

google-cla bot commented Apr 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mschneider82
Copy link
Contributor

the test failed because of go fmt was not executed on your modified file.

@Samarth08
Copy link
Contributor Author

@JeromeJu

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @Samarth08!

@aaron-prindle aaron-prindle merged commit d65b9b5 into GoogleContainerTools:main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --no-push and remote caching dont work with each other
3 participants