Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give warn instead of error when wildcard not match any files #3127

Merged

Conversation

prima101112
Copy link
Contributor

@prima101112 prima101112 commented Apr 21, 2024

give warn instead of error when wildcard not match any files

Fixes #3069 maybe also #3092

Description

give warn instead of error when wildcard not match any files.
follow docker behavior

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

this will give warn when copy with wildcard is not find any file.
but since its not returning any list file it will take fullfs snapshot instead of just take standard snapshot

@prima101112 prima101112 changed the title Copy with wildcard give warn instead of error when wildcard not match any files Apr 21, 2024
@prima101112
Copy link
Contributor Author

@aaron-prindle please review if you have spare time still not sure by the way since it will ignore some error that maybe is fatal intended.

Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR here @prima101112!

@aaron-prindle aaron-prindle merged commit 34905d6 into GoogleContainerTools:main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COPY with glob is incompatible with Docker
2 participants