Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for the --destination flag #3042

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nils-van-zuijlen
Copy link

Related to #217, #733

Description

Add documentation for the --destination flag to the readme.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests (Not needed for documentation?)
  • Adds integration tests if needed. (Not needed)

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

The flag is mostly self-explanatory, but its usage for multiple push
was not documented anywhere.

Related to GoogleContainerTools#217, GoogleContainerTools#733
Copy link

google-cla bot commented Mar 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nils-van-zuijlen
Copy link
Author

I unfortunately am not able to sign the CLA because I do not want a Google account, but I hereby set this commit in the public domain. Feel free to take its content in another MR by yourself, see ya!

@JeromeJu
Copy link
Collaborator

I unfortunately am not able to sign the CLA because I do not want a Google account, but I hereby set this commit in the public domain. Feel free to take its content in another MR by yourself, see ya!

Thanks @nils-van-zuijlen for this PR - would you mind trying signing the CLA not via corporate contributor but via individual contributor? In that way you might not need to opt for the way to have a google account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants