Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --skip-snapshot arg which skips all build snapshots #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Owez
Copy link

@Owez Owez commented Dec 8, 2023

Fixes #1615

Description

This PR adds a new --skip-snapshot argument which skips running any snapshots at all. Right now people run --single-snapshot for performance reasons, but an edge case is not taking any snapshots at all.

Two asterisks to this contrib:

  • I don't know much Go so I'm not sure where/how to add unit tests sorry.
  • I had a look through build() and I believe snapshots/cache are uploaded as and when rather than having any further processing, so not having any snapshots should be alright?

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- kaniko adds a new --skip-snapshot argument which skips taking any snapshots

Copy link

google-cla bot commented Dec 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: --snapshotMode=skip
1 participant