Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve sensetive data from the build context #1862

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented Dec 26, 2021

Fixes #1861

Description

PoC to hide sensitive data (docker's config.json) from the user

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- kaniko removes docker config when it is not mounted before the build and restores before the push

@kvaps kvaps force-pushed the preserve-sensetive-data branch 3 times, most recently from 8f5589b to f2eb3ac Compare December 26, 2021 23:50
@tejal29
Copy link
Member

tejal29 commented Feb 20, 2022

@kvaps Thank you for your PR. please add unit tests for the code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sensetive data from the build context
2 participants