Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build option to add architecture suffix to tags when publishing multi-platform images #3523

Merged
merged 8 commits into from
Dec 13, 2021

Conversation

taer
Copy link
Contributor

@taer taer commented Dec 7, 2021

a PoC for the issue I reported here: #3518

Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for looking into this! Just did an initial review and mostly had minor comments. One thing to note: we should introduce this option in the BuildContext.

@taer taer requested a review from mpeddada1 December 10, 2021 15:42
@taer
Copy link
Contributor Author

taer commented Dec 10, 2021

@mpeddada1 If this looks good, I'll look through how to get this wired into the actual gradle config

@chanseokoh
Copy link
Member

You can run ./gradlew dev to do automatic formatting, Javadoc checks, and run unit tests locally.

@taer
Copy link
Contributor Author

taer commented Dec 13, 2021

You can run ./gradlew dev to do automatic formatting, Javadoc checks, and run unit tests locally.

Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@chanseokoh
Copy link
Member

I did some refactoring here and there.

I'll leave this to @mpeddada1 for final approval.

@chanseokoh chanseokoh changed the title Prototype of an option to tag child images when publishing multi platfor Build option to add architecture suffix to tags when publishing multi-platform images Dec 13, 2021
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@mpeddada1 mpeddada1 merged commit 5a5fa5e into GoogleContainerTools:master Dec 13, 2021
@taer taer deleted the tagChild branch December 13, 2021 19:02
@taer
Copy link
Contributor Author

taer commented Feb 24, 2022

@mpeddada1 I'd like to open a new PR to expose this property to the gradle plugin. Any pointers to where that should land? I feel like it makes sense as jib.to.enablePlatformTags

@mpeddada1
Copy link
Contributor

Hi @taer, I think exposing it as jib.to.enablePlatformTags makes sense. We also include the option to add additional tags under jib.to. TargetImageParameters could be a good place to start:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants