-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build option to add architecture suffix to tags when publishing multi-platform images #3523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for looking into this! Just did an initial review and mostly had minor comments. One thing to note: we should introduce this option in the BuildContext
.
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/ContainerConfiguration.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/PushImageStep.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/PushImageStep.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/ContainerConfiguration.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
@mpeddada1 If this looks good, I'll look through how to get this wired into the actual gradle config |
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/PushImageStep.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/ContainerConfiguration.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/PushImageStepTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/PushImageStep.java
Outdated
Show resolved
Hide resolved
You can run |
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
Outdated
Show resolved
Hide resolved
Thanks! |
Kudos, SonarCloud Quality Gate passed! |
I did some refactoring here and there. I'll leave this to @mpeddada1 for final approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
@mpeddada1 I'd like to open a new PR to expose this property to the gradle plugin. Any pointers to where that should land? I feel like it makes sense as jib.to.enablePlatformTags |
Hi @taer, I think exposing it as jib/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TargetImageParameters.java Line 36 in 71e3977
|
a PoC for the issue I reported here: #3518