Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Application Default Credentials for Google Artifact Registry #3241

Merged
merged 2 commits into from
May 17, 2021
Merged

Support Application Default Credentials for Google Artifact Registry #3241

merged 2 commits into from
May 17, 2021

Conversation

chanseokoh
Copy link
Member

Fixes #3239.

@chanseokoh chanseokoh requested a review from mpeddada1 May 17, 2021 16:31
@google-cla google-cla bot added the cla: yes label May 17, 2021
mpeddada1
mpeddada1 approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanseokoh chanseokoh merged commit 026a263 into master May 17, 2021
@chanseokoh chanseokoh deleted the i3239-artifact-registry-adc branch May 17, 2021 17:55
@chanseokoh chanseokoh mentioned this pull request Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GOOGLE_APPLICATION_CREDENTIALS for Google's Artifact Registry (*-docker.pkg.dev)
2 participants
@chanseokoh @mpeddada1