Feature/set environment variable for cred helper #3093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd GradleRawConfiguration
…tialHelperFactory
…t options to processBuilder
chanseokoh
reviewed
Mar 3, 2021
| @@ -225,4 +221,22 @@ public Path getImageJsonOutputPath() { | |||
| public List<? extends PlatformConfiguration> getPlatforms() { | |||
| return jibExtension.getFrom().getPlatforms().get(); | |||
| } | |||
|
|
|||
| @Override | |||
| public Map<String, String> getFromEnvironment() { | |||
Comment on lines
+101
to
+110
| @Input | ||
| @Nullable | ||
| @Optional | ||
| public Map<String, String> getEnvironment() { | ||
| return environment; | ||
| } | ||
|
|
||
| public void setEnvironment(Map<String, String> environment) { | ||
| this.environment = environment; | ||
| } |
There was a problem hiding this comment.
The way we want is to set this through jib.from.credHelper.environment as I showed in #2814 (comment), not through jib.from.environment as you did here.
An important thing is to maintain backward compatibility. That is, all of these should work:
jib.from {
image = ...
credHelper = 'ecr-login`
}
jib.from {
image = ...
credHelper.helper = 'ecr-login'
}
jib.from {
image = ...
credHelper {
helper = 'ecr-login'
environment = ...
}
}
Comment on lines
+120
to
+129
| @Input | ||
| @Nullable | ||
| @Optional | ||
| public Map<String, String> getEnvironment() { | ||
| return environment; | ||
| } | ||
|
|
||
| public void setEnvironment(Map<String, String> environment) { | ||
| this.environment = environment; | ||
| } |
|
@vinod-tahelyani just checking in, do you still plan to complete this PR? |
|
Closing (#2814 (comment)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2814