Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics and tracing support for Java #13

Merged

Conversation

ericgribkoff
Copy link
Contributor

@ericgribkoff ericgribkoff commented Jan 26, 2021

Adds a command-line flag to turn on metrics and trace export. This depends on grpc/grpc-java#7746 which will be in the v1.36.0 release Edit: modified to be compatible with existing features in v1.35.0

@ericgribkoff ericgribkoff self-assigned this Jan 26, 2021
@ericgribkoff ericgribkoff changed the title Add metrics and tracing configuration support Add metrics and tracing configuration support for Java Jan 27, 2021
@ericgribkoff ericgribkoff changed the title Add metrics and tracing configuration support for Java Add metrics and tracing support for Java Jan 27, 2021
@ericgribkoff ericgribkoff assigned voidzcy and unassigned voidzcy and ericgribkoff Jan 29, 2021
Copy link

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the minor thing for String comparison.

@ericgribkoff ericgribkoff merged commit b9f28c9 into GoogleCloudPlatform:master Jan 29, 2021
@ericgribkoff ericgribkoff deleted the observability_java branch January 29, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants