-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #2576 Added typeadapter to read and write Instant values. #2841
feat: #2576 Added typeadapter to read and write Instant values. #2841
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
2ef4c76
to
7de8464
Compare
16614e4
to
603ce2f
Compare
603ce2f
to
212e9bc
Compare
Quality Gate passedIssues Measures |
...le/cloud/spring/data/spanner/core/convert/ConverterAwareMappingSpannerEntityReaderTests.java
Show resolved
Hide resolved
Retargeted this PR to new branch |
a795e67
into
GoogleCloudPlatform:feat/2576-instant-typeadapter
…o cover more cases. (GoogleCloudPlatform#2841)
This PR adds a default
TypeAdapter
to the Spanner Mapping Context, enabling seamless mapping of java.time.Instant. Consequently, the need to include--add-opens java.base/java.time=ALL-UNNAMED
in JVM arguments is eliminated.Solves #2576