Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2576 Added typeadapter to read and write Instant values. #2841

Conversation

ablx
Copy link
Contributor

@ablx ablx commented May 3, 2024

This PR adds a default TypeAdapter to the Spanner Mapping Context, enabling seamless mapping of java.time.Instant. Consequently, the need to include --add-opens java.base/java.time=ALL-UNNAMED in JVM arguments is eliminated.

Solves #2576

@ablx ablx requested a review from a team as a code owner May 3, 2024 07:31
Copy link

google-cla bot commented May 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ablx ablx changed the title Added typeadapter to read and write Instant values. #2576 Added typeadapter to read and write Instant values. May 3, 2024
Copy link

conventional-commit-lint-gcf bot commented May 3, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@ablx ablx changed the title #2576 Added typeadapter to read and write Instant values. feat: #2576 Added typeadapter to read and write Instant values. May 3, 2024
@ablx ablx force-pushed the feat/2576-instant-typeadapter branch from 2ef4c76 to 7de8464 Compare May 3, 2024 07:37
@ablx ablx force-pushed the feat/2576-instant-typeadapter branch 4 times, most recently from 16614e4 to 603ce2f Compare May 3, 2024 14:56
@ablx ablx force-pushed the feat/2576-instant-typeadapter branch from 603ce2f to 212e9bc Compare May 6, 2024 07:39
@burkedavison burkedavison self-assigned this May 14, 2024
@burkedavison burkedavison self-requested a review May 14, 2024 17:56
Copy link

sonarcloud bot commented May 14, 2024

@burkedavison burkedavison changed the base branch from main to feat/2576-instant-typeadapter May 14, 2024 20:26
@burkedavison
Copy link
Member

Retargeted this PR to new branch feat/2576-instant-typeadapter. Will need to merge it here and open a new PR into main to ensure integration tests are triggered.

@burkedavison burkedavison merged commit a795e67 into GoogleCloudPlatform:feat/2576-instant-typeadapter May 14, 2024
11 checks passed
ablx added a commit to ablx/spring-cloud-gcp that referenced this pull request May 15, 2024
burkedavison added a commit that referenced this pull request May 15, 2024
…ues (@ablx) (#2881)

* feat: #2576 Added typeadapter to read and write Instant values. (#2841)

* chore: additional test cases for InstantTypeAdapterTest

---------

Co-authored-by: Mirco Franzek <ablx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants