Add deletion-data-on-start flags as per go/gmp:oomcrashloop #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
bwplotka/del-flags
branch
from
3f60ccb
to
58d6157
Compare
bwplotka
changed the title
bwplotka
changed the title
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/del-flags
branch
from
58d6157
to
147982f
Compare
pintohutch
reviewed
Apr 17, 2024
TheSpiritXIII
approved these changes
Apr 18, 2024
pintohutch
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go/gmp:oomcrashloop and prometheus/prometheus#13939
I decided to slightly alter the flag name and instead create a specific fork GMP flag so it's explicit it's experimental and only in our fork. Some
--storage.agent.delete-data-on-startmight be accepted for agent, but unlikely for TSDB, also names might change, so let's not confuse users.