Vertex AI MLOps Accelerator #980
Conversation
There was a problem hiding this comment.
There is a binary file in this PR (examples/vertex-ai-mlops-accelerator/PREDICT/model.joblib). What is that file for? Is that file generated somehow by this example?
Please use a linter with the Python code to make the code compliant with PEP8 (for instance, you can use https://pypi.org/project/pylint/). I have added comments where I have caught inconsistencies, but I may have missed it in other places.
examples/vertex-ai-mlops-accelerator/CLOUD_FUNCTION/PUB_SUB_VERTEX_AI_TRIGGER/main.py
Outdated
Show resolved
Hide resolved
examples/vertex-ai-mlops-accelerator/CLOUD_FUNCTION/SCHEDULED_BATCH_PREDICTION_TRIGGER/main.py
Outdated
Show resolved
Hide resolved
examples/vertex-ai-mlops-accelerator/CLOUD_FUNCTION/PUB_SUB_VERTEX_AI_TRIGGER/config.ini
Outdated
Show resolved
Hide resolved
...les/vertex-ai-mlops-accelerator/CLOUD_FUNCTION/SCHEDULED_BATCH_PREDICTION_TRIGGER/config.ini
Outdated
Show resolved
Hide resolved
examples/vertex-ai-mlops-accelerator/CLOUD_RUN/PREDICTION_CLOUD_RUN/main.py
Outdated
Show resolved
Hide resolved
examples/vertex-ai-mlops-accelerator/VERTEX_AI/TRAINING_PIPELINE/worker_pool_specs.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
|
|
||
| stats_output = namedtuple('Outputs', ['worker_pool_specs']) |
There was a problem hiding this comment.
(following from previous comment) Then here you could just say:
stats_output = WorkerPoolOutput(Outputs=['worker_pool_specs'])
examples/vertex-ai-mlops-accelerator/VERTEX_AI/TRAINING_PIPELINE/worker_pool_specs.py
Outdated
Show resolved
Hide resolved
examples/vertex-ai-mlops-accelerator/VERTEX_AI/TRAINING_PIPELINE/worker_pool_specs.py
Outdated
Show resolved
Hide resolved
|
Most of the comments I made have not been addressed. There are no changes to the Python code, the same issues remain. Please could you take a look at the comments? |
|
@paragsmhatre Could you take a look at @iht 's comment? |
Yes sure @iht @agold-rh , I have 1. applied Pylint , 2.removed binary files 3. Cleanup non-required files as per suggestions. I will revist the code and try to resolve all comments. Thank you for the guidance. |
|
Closed as stale. If I'm wrong, please re-open. |
Generic accelerator for Machine Learning Operationalization using Vertex AI