Cleaning up linter errors from the Google Cloud Support Slackbot tool #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a link to the slackbot app
Cleaning up unused variables
Syncing fork
|
/gcbrun |
|
/gcbrun |
rosmo
pushed a commit
to rosmo/professional-services
that referenced
this pull request
Mar 17, 2022
…GoogleCloudPlatform#685) * Create README.md * Add files via upload * Create README.md * Add files via upload * Update README.md * Delete gcloud_buddy_small.png * Add files via upload * Update google_cloud_support_slackbot.py * Update README.md * Create .env * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Updating main README.md Adding a link to the slackbot app * Update google_cloud_support_slackbot.py * Update README.md * Update google_cloud_support_slackbot.py * Update README.md * Update google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py * Update requirements.txt * Update google_cloud_support_slackbot.py * Update README.md * Update README.md * Update google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py * Add files via upload * Add files via upload * Delete google_cloud_support_slackbot_icon_big.png * Delete google_cloud_support_slackbot_icon_small.png * Add files via upload * Delete google_cloud_support_buddy_small.png * Delete google_cloud_support_buddy_big.png * Update README.md * Add files via upload * Delete google_cloud_support_slackbot_icon_big.svg * Delete google_cloud_support_slackbot_icon_small.svg * Add files via upload * Update README.md * Update google_cloud_support_slackbot.py * Update .env * Update README.md * Update requirements.txt * Update google_cloud_support_slackbot.py Cleaning up unused variables * Delete google_cloud_support_slackbot.py * Update google_cloud_support_slackbot.py Co-authored-by: Israel Herraiz <ihr@google.com> Co-authored-by: Abdel SGHIOUAR <abdelfettah@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last pull request had linter errors which are causing issues for other pull requests (see #681). This PR is cleaning up just the google_cloud_support_slackbot.py file by logging all of the exceptions that can occur, and removing unused variables or replacing them with '_'.
Fixes #684