GKE custom organizational policies based on CIS Benchmarks #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@athankso60 Please take a look at the trigger failure. If you peek into helpers/check_format.sh, you will see the formatting tests that are run on the bash file type. The formatting errors I see are all in tools/gke-custom-org-policies/run.sh. |
| @@ -0,0 +1,123 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
the script contains arrays and [[ which are available in bash. The shebang line should be #!/bin/bash
| echo ${files[0]} | ||
| #run constraint | ||
| constraint=`cat ${files[0]}` | ||
| echo "${constraint/"[ORGANIZATIONID]"/$1}" > constraint.yaml |
There was a problem hiding this comment.
this is another bash line that may not work in a bourne shell
|
Closed as stale. Please re-open if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository is an attempt to provide sample organizational policies that could be enforced in order to comply with the GKE portion of CIS benchmarks.