CIS 4.01: Ensure that instances are not configured to use the default… #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… service account with full access to all Cloud APIs
charliewolf
requested review from
AdrienWalkowiak,
briantkennedy,
joecheuk,
morgante and
t12g
as code owners
charliewolf
force-pushed
the
feature/cis/4.01
branch
from
f39aa58
to
c6a0c8e
Compare
katze120
reviewed
Jan 6, 2020
|
|
||
| scope == "https://www.googleapis.com/auth/cloud-platform" | ||
|
|
||
| message := sprintf("Instance %v has default service account with full access to all Cloud APIs.", [asset.name]) |
There was a problem hiding this comment.
Looks like this block only checks scope but not service account
Suggest to add re_match("-compute@developer.gserviceaccount.com$", service_account.email) to check for default compute engine service account
If we use custom service account, scope will always be full scope, which is actually recommended: https://cloud.google.com/compute/docs/access/create-enable-service-accounts-for-instances#best_practices
There was a problem hiding this comment.
Thanks for the recommendation! @charliewolf what do you think about this strategy?
dekuhn
requested review from
gkowalski-google
and removed request for
joecheuk
|
@katze120 or @gkowalski-google can you help with data needed by Charlie base on the code review feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… service account with full access to all Cloud APIs