VPC-SC #2: Whitelist support for access levels #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliewolf
requested review from
AdrienWalkowiak,
briantkennedy,
joecheuk,
morgante and
t12g
as code owners
charliewolf
force-pushed
the
features/vpcsc/whitelist-levels
branch
from
ddcd57d
to
84ab0f4
Compare
joecheuk
suggested changes
Dec 27, 2019
| description: "Required access level names" | ||
| mode: | ||
| type: string | ||
| enum: [whitelist, blacklist, reqired] |
There was a problem hiding this comment.
type: reqired/required, do you mean require here (used below in the code)
There was a problem hiding this comment.
Enum has been corrected
charliewolf
force-pushed
the
features/vpcsc/whitelist-levels
branch
from
84ab0f4
to
b2a5c1d
Compare
joecheuk
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
@charliewolf
Can you also update the constraint inside the samples folder with the latest format?
|
@charliewolf @joecheuk @gkowalski-google is this ready for final approval / merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.