confgenerator: quoted map keys test #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit test for quoted map keys. Also does some minor maintenance on other tests: - The all_built-in tests are made obsolete by the specific builtin tests in the `builtin` directory - Add support for generating the `golden` directory when generating goldens for a new test Signed-off-by: braydonk <braydonk@google.com>
braydonk
requested review from
a team,
igorpeshansky and
sophieyfang
and removed request for
a team and
igorpeshansky
Updated go-yaml dependency and regenerated goldens for improved error messages from 1.9.6. Signed-off-by: braydonk <braydonk@google.com>
sophieyfang
approved these changes
Dec 5, 2022
|
Thanks for the reviews! Will re-run Unit Test check that failed, only Integration Test failure was a Windows flake so as long as unit tests pass I'll merge. |
sophieyfang
reviewed
Dec 5, 2022
They are in |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: braydonk braydonk@google.com
Description
Add unit test for quoted map keys. Also does some minor maintenance on other tests:
builtindirectorygoldendirectory when generating goldens for a new testRelated issue
b/260784354
Closes #994
#995
How has this been tested?
Unit tests were tested by running unit tests
Checklist: