Default to using FindDeafultCredentials for credentials #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using with workload identity federation
damemi
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This which allows using with workload identity federation as described in https://pkg.go.dev/golang.org/x/oauth2/google#hdr-Credentials.
This combines setProjectFromADC and generateClientOptions to limit startup to a single call to FindDeafultCredentials. It also ensures we only invoke FindDeafultCredentials when both project and impersonate config are already set.
This also fixes a bug with impersonate configuration: It always used the monitoring scopes, even for log and trace exporters. It now uses the correct scopes for the telemetry type.
Fixes #526